jvanstraten opened a new pull request #12457:
URL: https://github.com/apache/arrow/pull/12457
Initial attempt at making something functional to solve this issue properly.
The use of `add_arrow_lib` in `ThirdpartyToolchain.cmake` is certainly odd,
and I'm sure I'm not following best practices in that file in general. I could
use some advice on what the proper way to do this would be. Some of the issues:
- The CMake property specifying that a path refers to a generated file is
scoped only to the current CMake file, so only moving the `externalproject_add`
over to `ThirdpartyToolchain.cmake` resulted in the `add_arrow_lib` in
`src/arrow/engine` failing due to missing source files. An object library
didn't seem to resolve it either, and there are probably portability issues
with that anyway, so that's why I ended up just using `add_arrow_lib`.
- Unlike all the other third-party dependencies (AFAICT), Substrait can't
currently be installed, so `Substrait_SOURCE=SYSTEM` makes no sense. In the end
I just decided to override it, but that's probably not ideal.
- Substrait doesn't have releases yet, so I had to resort to a git hash
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
