jvanstraten commented on pull request #12457: URL: https://github.com/apache/arrow/pull/12457#issuecomment-1046796122
@kou Thanks for the input! It's certainly a lot nicer to do it that way, but unfortunately, we're not quite there yet... I got it working in most build environments using your diff with some minor changes (had to add protobuf to the include list for the object library, and add its runtime library to arrow_engine), but it fails [here](https://github.com/apache/arrow/runs/5272118026?check_suite_focus=true): ``` CMake Error at cmake_modules/BuildUtils.cmake:287 (add_library): OBJECT library "arrow_engine_objlib" contains: capabilities.pb.cc.o expression.pb.cc.o extensions.pb.cc.o function.pb.cc.o parameterized_types.pb.cc.o plan.pb.cc.o relations.pb.cc.o type.pb.cc.o type_expressions.pb.cc.o but may contain only sources that compile, header files, and other files that would not affect linking of a normal library. ``` I feel like the addition to BuildUtils.cmake is either causing this or supposed to resolve this (and failing to do so in this particular case), but other than that, my skill level for CMake is insufficient to see what exactly is going on here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
