yjshen commented on a change in pull request #1891:
URL: https://github.com/apache/arrow-datafusion/pull/1891#discussion_r816846933
##########
File path: datafusion/src/row/mod.rs
##########
@@ -349,6 +354,38 @@ mod tests {
assert_eq!(batch, output_batch);
Ok(())
}
+
+ #[test]
+ #[allow(non_snake_case)]
+ fn [<test_single_ $TYPE _nf>]() -> Result<()> {
Review comment:
I was trying to remove unnecessary null bits checking staff when tuples
are null_free according to their schema. Therefore, the null_free and not
null_free code paths have diverged.
To be specific, null bytes creation, checkings, settings will be removed for
null-free tuples and their access methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
