yjshen commented on a change in pull request #1891:
URL: https://github.com/apache/arrow-datafusion/pull/1891#discussion_r816848381
##########
File path: datafusion/src/row/reader.rs
##########
@@ -174,14 +184,22 @@ impl<'a> RowReader<'a> {
#[inline(always)]
fn null_bits(&self) -> &[u8] {
- let start = self.base_offset;
- &self.data[start..start + self.null_width]
+ if self.null_free {
+ &[]
+ } else {
+ let start = self.base_offset;
+ &self.data[start..start + self.null_width]
Review comment:
This is for not null_free code path. Actually this method shouldn't be
touched when tuples are null-free
##########
File path: datafusion/src/row/writer.rs
##########
@@ -17,19 +17,24 @@
//! Reusable row writer backed by Vec<u8> to stitch attributes together
+#[cfg(feature = "jit")]
use crate::error::Result;
#[cfg(feature = "jit")]
use crate::reg_fn;
#[cfg(feature = "jit")]
use crate::row::fn_name;
-use crate::row::{estimate_row_width, fixed_size, get_offsets, supported};
+use crate::row::{
+ estimate_row_width, fixed_size, get_offsets, schema_null_free, supported,
+};
use arrow::array::*;
use arrow::datatypes::{DataType, Schema};
use arrow::record_batch::RecordBatch;
use arrow::util::bit_util::{ceil, round_upto_power_of_2, set_bit_raw,
unset_bit_raw};
+#[cfg(feature = "jit")]
Review comment:
Ah, that would be great! Thanks for the offering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
