westonpace commented on a change in pull request #12533:
URL: https://github.com/apache/arrow/pull/12533#discussion_r817310102
##########
File path: r/src/compute-exec.cpp
##########
@@ -277,4 +277,18 @@ std::shared_ptr<compute::ExecNode>
ExecNode_ReadFromRecordBatchReader(
return MakeExecNodeOrStop("source", plan.get(), {}, options);
}
+// [[arrow::export]]
+std::shared_ptr<compute::ExecNode> ExecNode_TableSourceNode(
+ const std::shared_ptr<compute::ExecPlan>& plan,
+ const std::shared_ptr<arrow::Table>& table) {
+ arrow::compute::TableSourceNodeOptions options{
+ /*table=*/table,
+ // TODO: make batch_size configurable
+ /*batch_size=*/1048576
Review comment:
Yes. I wouldn't worry about making it configurable at the moment
either. If our default is non-ideal then we should be figuring out a
more-ideal default. At the moment I don't know of any case where a user will
have more information than us in picking a reasonable default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
