nealrichardson commented on a change in pull request #12533:
URL: https://github.com/apache/arrow/pull/12533#discussion_r818136658
##########
File path: r/R/dplyr.R
##########
@@ -151,8 +151,14 @@ dim.arrow_dplyr_query <- function(x) {
rows <- NA_integer_
} else if (isTRUE(x$filtered_rows)) {
rows <- x$.data$num_rows
- } else {
+ } else if (query_on_dataset(x)) {
+ # TODO: do this with an ExecPlan instead of Scanner?
Review comment:
```suggestion
# TODO: do this with an ExecPlan instead of Scanner (after ARROW-12311)?
# See also https://github.com/apache/arrow/pull/12533/files#r818129459
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
