jonkeane commented on a change in pull request #12433:
URL: https://github.com/apache/arrow/pull/12433#discussion_r818711237
##########
File path: r/tests/testthat/test-dplyr-funcs-type.R
##########
@@ -768,3 +769,138 @@ test_that("nested structs can be created from scalars and
existing data frames",
tibble(a = 1:2)
)
})
+
+test_that("as.Date() converts successfully from date, timestamp, integer, char
and double", {
+ test_df <- tibble::tibble(
+ posixct_var = as.POSIXct("2022-02-25 00:00:01", tz = "Europe/London"),
+ date_var = as.Date("2022-02-25"),
+ character_ymd_var = "2022-02-25 00:00:01",
+ character_ydm_var = "2022/25/02 00:00:01",
+ integer_var = 32L,
+ double_var = 34.56
+ )
+
+ # casting from POSIXct treated separately so we can skip on Windows
+ # TODO move the test for casting from POSIXct below once ARROW-13168 is done
+ compare_dplyr_binding(
+ .input %>%
+ mutate(
+ date_dv = as.Date(date_var),
+ date_char_ymd = as.Date(character_ymd_var, format = "%Y-%m-%d
%H:%M:%S"),
+ date_char_ydm = as.Date(character_ydm_var, format = "%Y/%d/%m
%H:%M:%S"),
+ date_int = as.Date(integer_var, origin = "1970-01-01")
+ ) %>%
+ collect(),
+ test_df
+ )
+
+ # the way we go about it is a bit different, but the result is the same =>
+ # testing without compare_dplyr_binding()
+ expect_equal(
+ test_df %>%
+ arrow_table() %>%
+ mutate(date_double = as.Date(double_var)) %>%
+ collect(),
+ test_df %>%
+ arrow_table() %>%
+ mutate(date_double = as.Date(double_var, origin = "1970-01-01")) %>%
+ collect()
+ )
+
+ expect_equal(
+ test_df %>%
+ record_batch() %>%
+ mutate(date_double = as.Date(double_var)) %>%
+ collect(),
+ test_df %>%
+ arrow_table() %>%
+ mutate(date_double = as.Date(double_var, origin = "1970-01-01")) %>%
+ collect()
+ )
+
+ # actual and expected differ due to doubles are accounted for (floored in
+ # arrow and rounded to the next decimal in R)
+ expect_error(
+ compare_dplyr_binding(
+ .input %>%
+ mutate(date_double = as.Date(double_var, origin = "1970-01-01")) %>%
+ collect(),
+ test_df
+ )
+ )
Review comment:
Thanks for all this exploration on `date64()` that's super super
helpful, and exactly the right approach for these kinds of problems. And thank
you for bringing this up in https://issues.apache.org/jira/browse/ARROW-15798
which is also a good place for it. I'll comment this there as well, but this
does make me wonder if our conversion of date64() from arrow -> POSIXct in R
might not be quite right! But we definitely don't need to tackle that in this
PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
