sanjibansg commented on a change in pull request #12560:
URL: https://github.com/apache/arrow/pull/12560#discussion_r819730497
##########
File path: cpp/src/arrow/dataset/scanner.cc
##########
@@ -708,8 +709,12 @@ Result<ProjectionDescr>
ProjectionDescr::FromNames(std::vector<std::string> name
for (size_t i = 0; i < exprs.size(); ++i) {
exprs[i] = compute::field_ref(names[i]);
}
+ auto fields = dataset_schema.fields();
+ for (const auto& aug_field : kAugmentedFields) {
+ fields.push_back(aug_field);
+ }
return ProjectionDescr::FromExpressions(std::move(exprs), std::move(names),
- dataset_schema);
+ Schema(fields));
Review comment:
As it was asked to have the filename as a column, thus I have included
it in the augmented fields as a scalar value, so that we can query for the
column from the dataset. Can there be a better approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
