wangfenjin commented on pull request #1386: URL: https://github.com/apache/arrow-rs/pull/1386#issuecomment-1059971584
Thank for @alamb and @tustvold for your review, I'll check all the comments and update the code later, response to some of your general comment: 1. About the protobuf dependency, I'll check IOx 's codebase to see if I can remove the rust_protobuf 2. As you suggested, I'll focus on server side in this PR, and leave client to the follow up. According to the cpp implementation, the client library logic might be more complex compared to server. 3. As you may have noted, I implement an example in https://github.com/wangfenjin/arrow-datafusion/pull/1 (we need to publish a new version then I can create MR to the arrow-datafusion repo). For the integration test, **_not sure if we need to implement it in this repo_**? Because if we implement one like [this](https://github.com/apache/arrow-rs/blob/master/arrow-flight/examples/server.rs) seems useless, and if we want to implement a useful example, we'd better depends on arrow-datafusion as we need a SQL server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
