lidavidm commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r820701040
##########
File path: cpp/src/arrow/flight/CMakeLists.txt
##########
@@ -197,7 +197,9 @@ add_arrow_lib(arrow_flight
${ARROW_FLIGHT_LINK_LIBS}
STATIC_LINK_LIBS
arrow_static
- ${ARROW_FLIGHT_LINK_LIBS})
+ ${ARROW_FLIGHT_LINK_LIBS}
+ ${ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL}
+ arrow_static)
Review comment:
Hmm, do we need to list arrow_static twice? And it seems odd that we
have to re-list all the libraries here…why doesn't listing arrow_static as a
dependency give us these dependencies transitively?
##########
File path: cpp/cmake_modules/BuildUtils.cmake
##########
@@ -240,7 +240,9 @@ function(ADD_ARROW_LIB LIB_NAME)
DEPENDENCIES
SHARED_INSTALL_INTERFACE_LIBS
STATIC_INSTALL_INTERFACE_LIBS
- OUTPUT_PATH)
+ OUTPUT_PATH
+ SHARED_INSTALL_EXTRA_TARGETS
+ STATIC_INSTALL_EXTRA_TARGETS)
Review comment:
Do we actually use any of the changes here anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
