lidavidm commented on a change in pull request #11889:
URL: https://github.com/apache/arrow/pull/11889#discussion_r820837421
##########
File path: cpp/cmake_modules/BuildUtils.cmake
##########
@@ -406,7 +406,8 @@ function(ADD_ARROW_LIB LIB_NAME)
"${_lib_install_name}")
endif()
- install(TARGETS ${LIB_NAME}_shared ${INSTALL_IS_OPTIONAL}
+ install(TARGETS ${LIB_NAME}_shared ${ARG_SHARED_INSTALL_EXTRA_TARGETS}
+ ${INSTALL_IS_OPTIONAL}
Review comment:
This change and the one below are also unnecessary right?
##########
File path: cpp/src/arrow/flight/CMakeLists.txt
##########
@@ -197,7 +197,8 @@ add_arrow_lib(arrow_flight
${ARROW_FLIGHT_LINK_LIBS}
STATIC_LINK_LIBS
arrow_static
- ${ARROW_FLIGHT_LINK_LIBS})
+ ${ARROW_FLIGHT_LINK_LIBS}
+ ${ARROW_STATIC_INSTALL_INTERFACE_LIBS_REAL})
Review comment:
FWIW, I tried just now and this addition here isn't necessary anymore -
it gets picked up transitively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
