xudong963 commented on a change in pull request #1943:
URL: https://github.com/apache/arrow-datafusion/pull/1943#discussion_r821290635
##########
File path: datafusion-expr/src/expr.rs
##########
@@ -399,7 +399,7 @@ impl fmt::Debug for Expr {
match self {
Expr::Alias(expr, alias) => write!(f, "{:?} AS {}", expr, alias),
Expr::Column(c) => write!(f, "{}", c),
- Expr::ScalarVariable(var_names) => write!(f, "{}",
var_names.join(".")),
+ Expr::ScalarVariable(_, var_names) => write!(f, "{}",
var_names.join(".")),
Review comment:
> it looks like the Debug implementation for Expr tries to print
SQL-compatible output
It's a good point, makes sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
