xudong963 commented on pull request #1943: URL: https://github.com/apache/arrow-datafusion/pull/1943#issuecomment-1061499463
> > How about trying to test the other type and check the type? I have a vague feeling that there will be some problems of type conversion involved > > Could you elaborate more on what kinds of issues you are expecting? > > The crux of this change is that, previously, the types of all `StaticVariable` type expressions was hardcoded to be `DataType::Utf8`; what this change does is add a way of having the variable provider specify the actual type of the value. It does not do any type conversions. Sorry for the confusion. I went through the original code and the changes made to this ticket. I found the changes will eventually generate `Expr::ScalarVariable` with data type in the logical plan phase. But In the physical phase, the ticket doesn't do anything with the data type. So I'm confused what problem does this ticket actually solve? I would appreciate it if you could give an example usage about the ticket to help me understand and learn ❤️, thanks @maxburke -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
