michalursa commented on a change in pull request #12067:
URL: https://github.com/apache/arrow/pull/12067#discussion_r821427378
##########
File path: cpp/src/arrow/compute/exec/key_hash.h
##########
@@ -32,76 +32,161 @@ namespace compute {
// Implementations are based on xxh3 32-bit algorithm description from:
// https://github.com/Cyan4973/xxHash/blob/dev/doc/xxhash_spec.md
//
-class Hashing {
+class Hashing32 {
Review comment:
This is vectorized version, the other is not. And hashes are not
identical. There are some simplifications made here that makes sense for hash
tables used in query processing but not outside of query processing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
