pitrou commented on pull request #12528: URL: https://github.com/apache/arrow/pull/12528#issuecomment-1062826028
@rok > Or are you proposing to not raise? I think that's a valid for nonexistent, but I'm not sure about ambiguous. E.g. ceil(t) falls to exact moment of DST switch and could return t or t + dst_offset. By definition of ceil(), it should return the smallest applicable value, so there is no ambiguity. @jorisvandenbossche > For example in the case of "non-existent" times, we are actually changing the resulting timestamp, and thus that also means it will not necessarily "follow" the rounding `multiple` and `unit`. I think in such cases, it might still be better to raise by default? That's true, though it only seems to trigger for "unusual" roundings. So we may want to add an option for non-existent timestamps, but it sounds less important than getting ambiguous timestamps right (which shouldn't require an option). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
