rok commented on pull request #12528: URL: https://github.com/apache/arrow/pull/12528#issuecomment-1063230460
> For example in the case of "non-existent" times, we are actually changing the resulting timestamp, and thus that also means it will not necessarily "follow" the rounding multiple and unit. I think in such cases, it might still be better to raise by default? We could catch these cases and implement logic to return correct multiple rounding. Then we wouldn't need any options and would never have to raise. I agree with the other conclusions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
