tustvold commented on a change in pull request #1418:
URL: https://github.com/apache/arrow-rs/pull/1418#discussion_r824040229



##########
File path: parquet/src/encodings/decoding.rs
##########
@@ -652,6 +652,14 @@ where
                 .bit_reader
                 .get_batch(&mut buffer[read..read + batch_to_read], bit_width);
 
+            if batch_read != batch_to_read {

Review comment:
       Prior to this change, the decoder would get stuck in an infinite loop if 
given a truncated page. I discovered this by accident whilst writing 
`test_delta_bit_packed_padding`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to