tustvold commented on a change in pull request #1418:
URL: https://github.com/apache/arrow-rs/pull/1418#discussion_r824043552
##########
File path: parquet/src/encodings/decoding.rs
##########
@@ -1326,6 +1335,83 @@ mod tests {
assert_eq!(result, vec![29, 43, 89]);
}
+ #[test]
+ fn test_delta_bit_packed_padding() {
+ // Page header
+ let header = vec![
+ // Page Header
+
+ // Block Size - 256
+ 128,
+ 2,
+ // Miniblocks in block,
+ 4,
+ // Total value count - 419
+ 128 + 35,
+ 3,
+ // First value - 7
+ 7,
+ ];
+
+ // Block Header
+ let block1_header = vec![
+ 0, // Min delta
+ 0, 1, 0, 0, // Bit widths
+ ];
+
+ // Mini-block 1 - bit width 0 => 0 bytes
+ // Mini-block 2 - bit width 1 => 8 bytes
+ // Mini-block 3 - bit width 0 => 0 bytes
+ // Mini-block 4 - bit width 0 => 0 bytes
+ let block1 = vec![0xFF; 8];
+
+ // Block Header
+ let block2_header = vec![
+ 0, // Min delta
+ 0, 1, 2, 0xFF, // Bit widths, including non-zero padding
+ ];
+
+ // Mini-block 1 - bit width 0 => 0 bytes
+ // Mini-block 2 - bit width 1 => 8 bytes
+ // Mini-block 3 - bit width 2 => 16 bytes
+ // Mini-block 4 - padding => no bytes
+ let block2 = vec![0xFF; 24];
+
+ let data: Vec<u8> = header
+ .into_iter()
+ .chain(block1_header)
+ .chain(block1)
+ .chain(block2_header)
+ .chain(block2)
+ .collect();
+
+ let length = data.len();
+
+ let ptr = BufferPtr::new(data);
+ let mut reader = BitReader::new(ptr.clone());
+ assert_eq!(reader.get_vlq_int().unwrap(), 256);
+ assert_eq!(reader.get_vlq_int().unwrap(), 4);
+ assert_eq!(reader.get_vlq_int().unwrap(), 419);
+ assert_eq!(reader.get_vlq_int().unwrap(), 7);
+
+ // Test output buffer larger than needed and not exact multiple of
block size
+ let mut output = vec![0_i32; 420];
+
+ let mut decoder = DeltaBitPackDecoder::<Int32Type>::new();
+ decoder.set_data(ptr.clone(), 0).unwrap();
+ assert_eq!(decoder.get(&mut output).unwrap(), 419);
+ assert_eq!(decoder.get_offset(), length);
Review comment:
Without the fix for #1417 this would fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
