robertwb commented on a change in pull request #11185: [BEAM-8019] Some
generalizations to support cross-language transforms.
URL: https://github.com/apache/beam/pull/11185#discussion_r397543233
##########
File path: sdks/python/apache_beam/pvalue.py
##########
@@ -208,9 +233,23 @@ def from_runner_api(proto, context):
# deserialization. It will be populated soon after this call, in
# Pipeline.from_runner_api(). This brief period is the only time that
# PCollection.pipeline is allowed to be None.
+
+ try:
+ element_type = context.element_type_from_coder_id(proto.coder_id)
Review comment:
Have this method do the ExternalCoder stuff rather than catching an
exception here. Possibly it would not even be needed if the coders map is
properly populated beforehand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
