robertwb commented on a change in pull request #11185: [BEAM-8019] Some 
generalizations to support cross-language transforms.
URL: https://github.com/apache/beam/pull/11185#discussion_r397539082
 
 

 ##########
 File path: sdks/python/apache_beam/coders/coders.py
 ##########
 @@ -1383,22 +1375,74 @@ def from_runner_api_parameter(payload, components, 
context):
         write_state_threshold=int(payload))
 
 
-class RunnerAPICoderHolder(Coder):
+class ElementTypeHolder(typehints.TypeConstraint):
+  """A dummy element type for external coders that cannot be parsed in 
Python"""
+  def __init__(self, coder, context):
 
 Review comment:
   s/coder/coder_proto/ to be clear what it is?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to