lukecwik commented on a change in pull request #11221: Add base SDK version to
environment capabilities for Python and Java.
URL: https://github.com/apache/beam/pull/11221#discussion_r398654663
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java
##########
@@ -239,6 +239,7 @@ public static Environment createProcessEnvironment(
capabilities.addAll(ModelCoders.urns());
capabilities.add(BeamUrns.getUrn(StandardProtocols.Enum.MULTI_CORE_BUNDLE_PROCESSING));
capabilities.add(BeamUrns.getUrn(StandardProtocols.Enum.PROGRESS_REPORTING));
+ capabilities.add("beam:version:sdk_base:" +
JAVA_SDK_HARNESS_CONTAINER_URL);
Review comment:
What about going with `"beam:sdk:version:" +
ReleaseInfo.getReleaseInfo().getSdkVersion()` and `"beam:sdk:language:java"`?
Any detection we do about container image paths should likely be done from
the container manifest itself.
We could add `beam:sdk:language:go` to the Go SDK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
