lukecwik commented on a change in pull request #11221: Add base SDK version to
environment capabilities for Python and Java.
URL: https://github.com/apache/beam/pull/11221#discussion_r398774739
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java
##########
@@ -239,6 +239,7 @@ public static Environment createProcessEnvironment(
capabilities.addAll(ModelCoders.urns());
capabilities.add(BeamUrns.getUrn(StandardProtocols.Enum.MULTI_CORE_BUNDLE_PROCESSING));
capabilities.add(BeamUrns.getUrn(StandardProtocols.Enum.PROGRESS_REPORTING));
+ capabilities.add("beam:version:sdk_base:" +
JAVA_SDK_HARNESS_CONTAINER_URL);
Review comment:
The language version is an interesting point and brings up an issue where
you could be using the same base container but the user submitting the pipeline
is using a different version.
I just feel as though people will attempt to "parse" the language and
version out of the container URL but if it comes to that we can always add more
capabilities and remove existing ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
