lukecwik commented on a change in pull request #11184: [BEAM-4374] Update
protos related to MonitoringInfo.
URL: https://github.com/apache/beam/pull/11184#discussion_r398843062
##########
File path: model/pipeline/src/main/proto/metrics.proto
##########
@@ -33,14 +33,17 @@ import "beam_runner_api.proto";
import "google/protobuf/descriptor.proto";
import "google/protobuf/timestamp.proto";
-// A specification containing required set of fields and labels required
-// to be set on a MonitoringInfo for the specific URN for SDK->RunnerHarness
-// ProcessBundleResponse reporting.
+// A specification for describing a well known MonitoringInfo.
message MonitoringInfoSpec {
+ // Defines the semantic meaning of the metric or monitored state.
string urn = 1;
- string type_urn = 2;
- // The list of required
+
+ // Defines the encoding and aggregation method for the payload.
+ string type = 2;
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
