boyuanzz commented on a change in pull request #11199: [BEAM-9562][WIP] Update
Timer encoding with respect of dynamic timers
URL: https://github.com/apache/beam/pull/11199#discussion_r399740242
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ParDoTranslation.java
##########
@@ -197,7 +199,7 @@ public boolean canTranslate(PTransform<?, ?> pTransform) {
((KvCoder) mainInput.getCoder()).getKeyCoder(),
// TODO: Add support for timer payloads to the SDK
// We currently assume that all payloads are unspecified.
- Timer.Coder.of(VoidCoder.of())));
+ Timer.Coder.of(StringUtf8Coder.of(),
GlobalWindow.Coder.INSTANCE)));
Review comment:
I chose `StringUtf8Coder` for convenience since there is no place actually
parsing this key. I plan to plump through actual coders when migrating to use
data channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
