boyuanzz commented on a change in pull request #11199: [BEAM-9562][WIP] Update
Timer encoding with respect of dynamic timers
URL: https://github.com/apache/beam/pull/11199#discussion_r400607853
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Timer.java
##########
@@ -40,14 +49,26 @@
@AutoValue
public abstract class Timer<T> {
- /** Returns a timer for the given timestamp with a {@code null} payload. */
- public static Timer<Void> of(Instant time) {
- return of(time, (Void) null);
+ /**
+ * Returns a timer for the given timestamp with a user specified payload.
+ *
+ * @return
+ */
+ // TODO(BEAM-9562): Plumb through actual Timer fields.
+ public static <T> Timer<T> of(
Review comment:
Thanks for you suggestion! I really like this idea. I planned to refine the
signature when moving to data channel, but I can do it in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
