iemejia commented on a change in pull request #11258: [BEAM-9571] Add 
withMongoClientProvider to MongoDbIO
URL: https://github.com/apache/beam/pull/11258#discussion_r399772016
 
 

 ##########
 File path: 
sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java
 ##########
 @@ -166,7 +165,7 @@ private MongoDbIO() {}
 
     abstract SerializableFunction<MongoCollection<Document>, 
MongoCursor<Document>> queryFn();
 
-    abstract Builder builder();
+    abstract Builder toBuilder();
 
 Review comment:
   This rename is slightly unrelated to this PR but an improvement to be 
consistent with [AutoValue 
conventions](https://github.com/google/auto/blob/master/value/userguide/builders-howto.md#to_builder).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to