iemejia commented on a change in pull request #11258: [BEAM-9571] Add
withMongoClientProvider to MongoDbIO
URL: https://github.com/apache/beam/pull/11258#discussion_r400785847
##########
File path:
sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java
##########
@@ -191,7 +193,29 @@ private MongoDbIO() {}
abstract Builder setQueryFn(
SerializableFunction<MongoCollection<Document>,
MongoCursor<Document>> queryBuilder);
- abstract Read build();
Review comment:
This one was not renamed, it changed because now it has a default
implementation (see below in line 208). The default implementation sets a
provider given the respective parameters.
Oh I think I see where the confusion was, the rename was from `builder()` to
`toBuilder()` to follow AutoValue's recommendations and be consistent with most
of the other IOs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
