lukecwik commented on a change in pull request #11271: [BEAM-9624] Adds Convert
to Accumulators operator for use in combiner lifting for streaming pipelines
URL: https://github.com/apache/beam/pull/11271#discussion_r400610628
##########
File path: sdks/go/pkg/beam/core/runtime/exec/combine.go
##########
@@ -499,3 +499,30 @@ func (n *ExtractOutput) ProcessElement(ctx
context.Context, value *FullValue, va
}
return n.Out.ProcessElement(n.Combine.ctx, &FullValue{Windows:
value.Windows, Elm: value.Elm, Elm2: out, Timestamp: value.Timestamp})
}
+
+// ConvertToAccumulators is an executor for converting an input value to an
accumulator value.
+type ConvertToAccumulators struct {
+ *Combine
+}
+
+func (n *ConvertToAccumulators) String() string {
Review comment:
Please add a test like Combine/LiftedCombine:
https://github.com/apache/beam/blob/c8e200b157b43ad471c9480f8f617d9fbef33070/sdks/go/pkg/beam/core/runtime/exec/combine_test.go#L84
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
