lukecwik commented on a change in pull request #11271: [BEAM-9624] Adds Convert
to Accumulators operator for use in combiner lifting for streaming pipelines
URL: https://github.com/apache/beam/pull/11271#discussion_r400609084
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PTransformTranslation.java
##########
@@ -101,6 +101,8 @@
"beam:transform:combine_per_key_merge_accumulators:v1";
public static final String COMBINE_PER_KEY_EXTRACT_OUTPUTS_TRANSFORM_URN =
"beam:transform:combine_per_key_extract_outputs:v1";
+ public static final String
COMBINE_PER_KEY_CONVERT_TO_ACCUMULATORS_TRANSFORM_URN =
Review comment:
Please add to the checkState in the static initialization block to make sure
this value doesn't deviate from the string constant here.
Note, we do it this way so the Java compiler can treat the value as a string
constant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
