lukecwik commented on a change in pull request #11199: [BEAM-9562] Update Timer
encoding with respect of dynamic timers
URL: https://github.com/apache/beam/pull/11199#discussion_r402410797
##########
File path:
model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml
##########
@@ -207,15 +224,19 @@ examples:
coder:
urn: "beam:coder:timer:v1"
- components: [{urn: "beam:coder:bytes:v1"}]
+ components: [{urn: "beam:coder:string_utf8:v1"},
+ {urn: "beam:coder:global_window:v1"}]
examples:
- "\0\0\0\0\0\0\0\0\u0003abc": {timestamp: -9223372036854775808, payload: abc}
- "\x7fÿÿÿÿÿÿ\x01\u0003abc": {timestamp: -255, payload: abc}
- "\x7fÿÿÿÿÿÿÿ\u0003abc": {timestamp: -1, payload: abc}
- "\x80\0\0\0\0\0\0\0\u0003abc": {timestamp: 0, payload: abc}
- "\x80\0\0\0\0\0\0\x01\u0003abc": {timestamp: 1, payload: abc}
- "\x80\0\0\0\0\0\x01\0\u0003abc": {timestamp: 256, payload: abc}
- "ÿÿÿÿÿÿÿÿ\u0003abc": {timestamp: 9223372036854775807, payload: abc}
+
"\u0003\u006b\u0065\u0079\u0003\u0074\u0061\u0067\u0000\u0080\u0000\u0000\u0000\u0000\u0000\u0003\u00e8\u0080\u0000\u0000\u0000\u0000\u0000\u0003\u00e8\u0000\u0000\u0000\u0001\u000f":
{
Review comment:
Please add a test for a cleared timer encoding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
