lukecwik commented on a change in pull request #11199: [BEAM-9562] Update Timer
encoding with respect of dynamic timers
URL: https://github.com/apache/beam/pull/11199#discussion_r402692551
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/TimerTest.java
##########
@@ -33,42 +35,128 @@
/** Tests for {@link Timer}. */
@RunWith(JUnit4.class)
public class TimerTest {
- private static final Instant INSTANT = Instant.now();
+ private static final Instant FIREINSTANT = new Instant(123L);
+ private static final Instant HOLDINSTANT = new Instant(456L);
Review comment:
```suggestion
private static final Instant FIRE_TIME = new Instant(123L);
private static final Instant HOLD_TIME = new Instant(456L);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
