pawelpasterz commented on a change in pull request #11236: [BEAM-7505] Create
SideInput Python Jenkins jobs
URL: https://github.com/apache/beam/pull/11236#discussion_r402770026
##########
File path: .test-infra/jenkins/LoadTestConfig.groovy
##########
@@ -202,6 +201,20 @@ class LoadTestConfig implements
SerializableOption<Map<String, Serializable>> {
return ConfigHelper.convertProperties(config.propertiesMap)
}
+ /**
+ * Extends LoadTestConfig object by appending the given settings
+ * @param templateConfig LoadTestConfig instance
+ * @param cl Closure with settings
+ * @return LoadTestConfig object
+ */
+ static LoadTestConfig extend(final LoadTestConfig templateConfig, final
Closure cl = {}) {
Review comment:
I am wondering if we should rename this method so its name would tell us
what is being extended. Just thinking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
