pawelpasterz commented on a change in pull request #11236: [BEAM-7505] Create
SideInput Python Jenkins jobs
URL: https://github.com/apache/beam/pull/11236#discussion_r402768028
##########
File path: .test-infra/jenkins/LoadTestConfig.groovy
##########
@@ -182,10 +183,8 @@ class LoadTestConfig implements
SerializableOption<Map<String, Serializable>> {
* @see LoadTestConfig#templateConfig
*/
static Map<String, Serializable> fromTemplate(final LoadTestConfig
templateConfig, final Closure cl = {}) {
- final def newConfig = of(templateConfig)
- delegateAndInvoke(newConfig, cl)
+ final def newConfig = extend(templateConfig, cl)
final def properties = newConfig.propertiesMap
- verifyProperties(properties)
return ConfigHelper.convertProperties(properties)
Review comment:
With this refactor I think we could simplify this method to one line,
something like:
`return ConfigHelper.convertProperties(extend(templateConfig,
cl).propertiesMap)`
Or if we want to keep explicit
```
final def properties = extend(...).propertiesMap
return ConfigHelper.convertProperties(properties)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
