TheNeuralBit commented on a change in pull request #10055: [BEAM-8603] Add
Python SqlTransform
URL: https://github.com/apache/beam/pull/10055#discussion_r403515620
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/SqlTransform.java
##########
@@ -271,6 +275,19 @@ static Builder builder() {
abstract Builder setDefaultTableProvider(@Nullable String
defaultTableProvider);
abstract SqlTransform build();
+
+ @Override
+ public PTransform<PInput, PCollection<Row>> buildExternal(
+ External.Configuration configuration) {
+ return builder()
Review comment:
To be general purpose we'd also need a way to define a mapping for
non-primitive values e.g. JSON string -> `QueryParameters`. This is sort of
like logical types, but we only need one direction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
