TheNeuralBit commented on a change in pull request #10055: [BEAM-8603] Add
Python SqlTransform
URL: https://github.com/apache/beam/pull/10055#discussion_r403514475
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1779,6 +1779,33 @@ class BeamModulePlugin implements Plugin<Project> {
cleanupTask.mustRunAfter pythonTask
config.cleanupJobServer.mustRunAfter pythonTask
}
+ // Task for running testcases in Python SDK
+ def testOpts = [
+ "--attr=UsesSqlExpansionService"
+ ]
+ def pipelineOpts = [
+ "--runner=PortableRunner",
+ "--environment_cache_millis=10000",
+ "--job_endpoint=${config.jobEndpoint}"
+ ]
+ def beamPythonTestPipelineOptions = [
+ "pipeline_opts": pipelineOpts,
+ "test_opts": testOpts,
+ "suite": "xlangSqlValidateRunner"
+ ]
+ def cmdArgs =
project.project(':sdks:python').mapToArgString(beamPythonTestPipelineOptions)
+ def pythonSqlTask = project.tasks.create(name:
config.name+"PythonUsingSql", type: Exec) {
Review comment:
This is outside of the `['Java': javaPort, 'Python': pythonPort].each` block
so I don't think it will get created twice. Is there an advantage to adding SQL
to the testing expansion service over just using the SQL expansion service
directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
