lukecwik commented on a change in pull request #11325: [BEAM-4374, BEAM-6189]
Delete and remove deprecated Metrics proto
URL: https://github.com/apache/beam/pull/11325#discussion_r404389323
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/BeamFnMapTaskExecutor.java
##########
@@ -341,30 +339,16 @@ void updateProgress() {
grpcWriteOperation.abortWait();
}
- // TODO(BEAM-6189): Replace getProcessBundleProgress with
getMonitoringInfos when Metrics
- // is deprecated.
ProcessBundleProgressResponse processBundleProgressResponse =
MoreFutures.get(bundleProcessOperation.getProcessBundleProgress());
final List<MonitoringInfo> monitoringInfosList =
processBundleProgressResponse.getMonitoringInfosList();
- // Supporting deprecated metrics until all supported runners are
migrated to using
- // MonitoringInfos
- Metrics metrics = processBundleProgressResponse.getMetrics();
- double elementsConsumed =
-
bundleProcessOperation.getInputElementsConsumed(monitoringInfosList);
-
- if (elementsConsumed == 0) {
- elementsConsumed =
bundleProcessOperation.getInputElementsConsumed(metrics);
- }
-
updateMetrics(monitoringInfosList);
- updateMetricsDeprecated(metrics);
Review comment:
Go SDK has, @lostluck and I worked on the changes. See:
https://github.com/apache/beam/blob/aff446171b5ed77cdca6347ab6e3e597c096af91/sdks/go/pkg/beam/core/runtime/harness/monitoring.go#L204
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
