ajamato commented on a change in pull request #11325: [BEAM-4374, BEAM-6189]
Delete and remove deprecated Metrics proto
URL: https://github.com/apache/beam/pull/11325#discussion_r404379886
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -253,18 +253,13 @@ message ProcessBundleRequest {
}
message ProcessBundleResponse {
- // (Optional) If metrics reporting is supported by the SDK, this represents
- // the final metrics to record for this bundle.
- // DEPRECATED
- Metrics metrics = 1;
-
// (Optional) Specifies that the bundle has not been completed and the
// following applications need to be scheduled and executed in the future.
// A runner that does not yet support residual roots MUST still check that
// this is empty for correctness.
repeated DelayedBundleApplication residual_roots = 2;
- // (Required) The list of metrics or other MonitoredState
+ // DEPRECATED (Required) The list of metrics or other MonitoredState
// collected while processing this bundle.
repeated org.apache.beam.model.pipeline.v1.MonitoringInfo monitoring_infos =
3;
Review comment:
Why are these also deprecated now?
Will you be only using the bytes map now? I don't really get how this will
work by looking at the ProcessBundle(Progress)Response protos. It seems like
you would need the MonitoringInfo at least once to be able to decode the bytes.
I don't really understand the protocol that you have in mind here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
