robertwb commented on a change in pull request #11314: [WIP] Send Timers over
Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r405102954
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -1294,16 +1295,43 @@ def _pardo_fn_data(self):
windowing = None
return self.fn, self.args, self.kwargs, si_tags_and_types, windowing
- def to_runner_api_parameter(self, context):
+ def to_runner_api(self, context, main_inputs, has_parts=False):
Review comment:
This is starting to look like a lot of code duplication. How about we pass
(all) inputs as a keyword argument, and let `PTransform.to_runner_api` take an
`**extra_kwargs` that it passes on to `to_runner_api_parameter`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
