robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers
over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r405824290
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -1088,6 +1142,30 @@ def create_operation(self,
transform_proto.spec.payload, parameter_type)
return creator(self, transform_id, transform_proto, payload, consumers)
+ def get_timer_coders(self):
+ timer_coder = {}
+ for transform_id, transform_proto in self.descriptor.transforms.items():
Review comment:
I see us doing this loop three times now. Perhaps it would be more useful to
do the loop once to set everything up, creating a single dictionary
(transform_id, timer_family_id) -> (all info about that timer we need to
dispatch them).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
