regadas commented on a change in pull request #11275: [BEAM-9648]: DirectRunner
should return null on timeout
URL: https://github.com/apache/beam/pull/11275#discussion_r405888827
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/ExecutorServiceParallelExecutor.java
##########
@@ -260,6 +260,11 @@ public State waitUntilFinish(Duration duration) throws
Exception {
}
}
}
+
+ if (Instant.now().isAfter(completionTime)) {
+ return null;
+ }
Review comment:
Cleaned it up a little bit more and kept `(update == null &&
pipelineState.get().isTerminal())` to ensure that if an update has a
`Throwable` it gets thrown. (keeps previous semantic).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
