regadas commented on a change in pull request #11275: [BEAM-9648]: DirectRunner
should return null on timeout
URL: https://github.com/apache/beam/pull/11275#discussion_r405889052
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/ExecutorServiceParallelExecutor.java
##########
@@ -269,7 +277,7 @@ public State getPipelineState() {
}
private boolean isTerminalStateUpdate(VisibleExecutorUpdate update) {
- return !(update.getNewState() == null &&
update.getNewState().isTerminal());
+ return update.getNewState() != null && update.getNewState().isTerminal();
Review comment:
@lukecwik also found out that this conditional would throw an NPE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
