thetorpedodog commented on issue #11359: [BEAM-9731] Include more detail in 
passert.Equals errors.
URL: https://github.com/apache/beam/pull/11359#issuecomment-611343232
 
 
   R: @lostluck 
   
   Some notes:
   
   I chose a somewhat gawdy format for this just to make it very highly visible 
and easy-to-read on the terminal. I find it works pretty well, but I'm open to 
suggestions. Here's the output from one of the test cases:
   
   ```
   actual PCollection does not match expected values
   =========
   2 correct entries (present in both)
   =========
   1 unexpected entries (present in actual, missing in expected)
   +++
   too many
   =========
   1 missing entries (missing in actual, present in expected)
   ---
   not enough
   ```
   
   The checklist suggests updating `CHANGES.md`. This seems a bit small for 
that.
   
   This is covered by the Google CLA.
   
   Thanks for the review!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to