lostluck commented on a change in pull request #11359: [BEAM-9731] Include more detail in passert.Equals errors. URL: https://github.com/apache/beam/pull/11359#discussion_r406310025
########## File path: sdks/go/pkg/beam/testing/passert/passert.go ########## @@ -32,29 +32,6 @@ import ( //go:generate starcgen --package=passert --identifiers=diffFn,failFn,failKVFn,failGBKFn,hashFn,sumFn Review comment: failIfBadEntries should be added, at least, and technically, `go generate` should be run to update the .shim.go file. Given there's work to be done in the code generator in the next month or so, and that this is just for testing, I'm less worried about not having the shim file updated. Having the identifier added though is important to avoid losing it later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
