robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers
over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r405999346
##########
File path: sdks/python/apache_beam/runners/worker/data_plane.py
##########
@@ -372,12 +428,18 @@ def input_elements(self,
t, v, tb = self._exc_info
raise_(t, v, tb)
else:
- # TODO(BEAM-9558): Cleanup once dataflow is updated.
- if not data.data or data.is_last:
- done_transforms.add(data.transform_id)
- else:
- assert data.transform_id not in done_transforms
- yield data
+ if isinstance(element, beam_fn_api_pb2.Elements.Timer):
+ if element.is_last:
+ done_inputs.add((element.transform_id, element.timer_family_id))
+ else:
+ yield element
+ if isinstance(element, beam_fn_api_pb2.Elements.Data):
Review comment:
elif
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
