robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers
over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r405998009
##########
File path: sdks/python/apache_beam/runners/worker/data_plane.py
##########
@@ -274,20 +301,47 @@ def inverse(self):
return self._inverse
def input_elements(self,
- instruction_id, # type: str
- unused_expected_transforms=None, # type:
Optional[Collection[str]]
- abort_callback=None # type: Optional[Callable[[], bool]]
- ):
- # type: (...) -> Iterator[beam_fn_api_pb2.Elements.Data]
Review comment:
It'd be good to not lose the typing information. You can make an alias at
the top of the file `DataOrTimers = Union[beam_fn_api_pb2.Elements.Data,
beam_fn_api_pb2.Elements.Timer]` to cut down on verbosity, here and elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
