KevinGG commented on a change in pull request #11338: [BEAM-7923] Screendiff
Integration Tests
URL: https://github.com/apache/beam/pull/11338#discussion_r406345320
##########
File path: sdks/python/setup.py
##########
@@ -220,8 +220,21 @@ def get_version():
INTERACTIVE_BEAM = [
'facets-overview>=1.0.0,<2',
'ipython>=5.8.0,<8',
+ 'ipykernel>=5.2.0,<6',
Review comment:
It's also part of the Jupyter notebook setup dependency, see the
[readme](https://github.com/apache/beam/tree/master/sdks/python/apache_beam/runners/interactive).
We didn't put `jupyterlab` nor `ipykernel` in `[interactive]` because we
wanted to keep the dependency minimal sized. Since now we may need `ipykernel`
in the virtual env setup, add it to `[interactive]` because it's where it
should go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
