KevinGG commented on a change in pull request #11338: [BEAM-7923] Screendiff
Integration Tests
URL: https://github.com/apache/beam/pull/11338#discussion_r406351185
##########
File path: sdks/python/setup.py
##########
@@ -220,8 +220,21 @@ def get_version():
INTERACTIVE_BEAM = [
'facets-overview>=1.0.0,<2',
'ipython>=5.8.0,<8',
+ 'ipykernel>=5.2.0,<6',
Review comment:
It's actually related, because the nbconvert module requires an ipykernel to
work.
So this dependency is needed by both `[interactive]` and
`[interactive_test]`.
It looks weird to put it in `[interactive]` rather than `[interactive_test]`
though :), but that's where it should have been.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
