reuvenlax commented on a change in pull request #11350: [BEAM-1589] Added
@onWindowExpiration annotation.
URL: https://github.com/apache/beam/pull/11350#discussion_r406508479
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/DoFnRunner.java
##########
@@ -52,6 +52,12 @@ void onTimer(
*/
void finishBundle();
+ /**
+ * Calls a {@link DoFn DoFn's} {@link DoFn.OnWindowExpiration
@OnWindowExpiration} method and
+ * performs additional task, such as extracts a value saved in a state
before garbage collection.
+ */
+ void onWindowExpiration(BoundedWindow window, Instant timestamp, TimeDomain
timeDomain);
Review comment:
What do timestamp and timeDomain mean in this context?
Also presumably you do want to be able to access the key in
onWindowExpiration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
