reuvenlax commented on a change in pull request #11350: [BEAM-1589] Added
@onWindowExpiration annotation.
URL: https://github.com/apache/beam/pull/11350#discussion_r406510585
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java
##########
@@ -591,7 +591,7 @@ public void flushState() {
timerId,
"",
cleanupTime,
- cleanupTime,
Review comment:
We also seem to set GC timers in ReduceFnRunner.java. @kennknowles do you
know why we have both?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services