jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io
URL: https://github.com/apache/beam/pull/11151#discussion_r406551322
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -454,6 +455,7 @@ class BeamModulePlugin implements Plugin<Project> {
google_api_services_clouddebugger :
"com.google.apis:google-api-services-clouddebugger:v2-rev20191003-$google_clients_version",
google_api_services_cloudresourcemanager :
"com.google.apis:google-api-services-cloudresourcemanager:v1-rev20191206-$google_clients_version",
google_api_services_dataflow :
"com.google.apis:google-api-services-dataflow:v1b3-rev20190927-$google_clients_version",
+ google_api_services_healthcare :
"com.google.apis:google-api-services-healthcare:v1alpha2-rev20190901-$google_cloud_healthcare_version",
Review comment:
I'm rather new to these generated clients and beam.
Is there any process this community has followed in the past for finding a
suitable version in situations like this?
Seems like a lot for this PR to make this rather global upgrade.
Naturally if I just flip google_clients_version to 1.30.9 it breaks a lot:
```
Could not determine the dependencies of task ':sdks:java:harness:shadowJar'.
> Could not resolve all dependencies for configuration
':sdks:java:harness:runtimeClasspath'.
> Could not find
com.google.apis:google-api-services-cloudresourcemanager:v1-rev20191206-1.30.9.
Required by:
project :sdks:java:harness > project
:sdks:java:extensions:google-cloud-platform-core
> Could not find
com.google.apis:google-api-services-storage:v1-rev20191011-1.30.9.
Required by:
project :sdks:java:harness > project
:sdks:java:extensions:google-cloud-platform-core
> Could not find com.google.oauth-client:google-oauth-client:1.30.9.
> Could not find
com.google.apis:google-api-services-storage:v1-rev20191011-1.30.9.
Required by:
project :sdks:java:harness > project
:sdks:java:extensions:google-cloud-platform-core >
com.google.cloud.bigdataoss:gcsio:2.0.0
project :sdks:java:harness > project
:sdks:java:extensions:google-cloud-platform-core >
com.google.cloud.bigdataoss:util:2.0.0
> Could not find com.google.oauth-client:google-oauth-client:1.30.9.
Required by:
project :sdks:java:harness > project
:sdks:java:extensions:google-cloud-platform-core >
com.google.cloud.bigdataoss:gcsio:2.0.0
project :sdks:java:harness > project
:sdks:java:extensions:google-cloud-platform-core >
com.google.cloud.bigdataoss:util:2.0.0
> Could not find com.google.oauth-client:google-oauth-client-java6:1.30.9.
Required by:
project :sdks:java:harness > project
:sdks:java:extensions:google-cloud-platform-core >
com.google.cloud.bigdataoss:gcsio:2.0.0
project :sdks:java:harness > project
:sdks:java:extensions:google-cloud-platform-core >
com.google.cloud.bigdataoss:util:2.0.0
> Could not find com.google.oauth-client:google-oauth-client-java6:1.30.9.
Required by:
project :sdks:java:harness > project
:sdks:java:extensions:google-cloud-platform-core >
com.google.cloud.bigdataoss:gcsio:2.0.0 >
com.google.api-client:google-api-client-java6:1.30.9
*
```
seems like our culprits are
- [ ] `google-oauth-client`
- [ ] `google-oauth-client-java6`
- [ ] `google-api-services-storage`
If I go in and try to massage the revision numbers to make this work how
will I ensure that all those reliant on those deps are still working? Is that
covered in pre/post commit ITs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
